Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send email alerts on privacy request failures #1793

Merged
merged 21 commits into from
Dec 8, 2022
Merged

Send email alerts on privacy request failures #1793

merged 21 commits into from
Dec 8, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Nov 16, 2022 •
edited
Loading

Closes #1493

Code Changes

  • Added table to store notification preference information
  • Added table to track errors and if emails have been sent
  • Added new email template for error notifications
  • Trigger emails to be sent when the number of unsent errors reaches the specified threshold.

Steps to Confirm

  • Set the notification service type to MAILGUN in the config
  • Add mailgun config information
  • Use the privacy-request/notification route to add an email address to receive notifications and set the notification threshold.
  • Create enough errored privacy requests to reach the email threashold.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

@sanders41 sanders41 marked this pull request as ready for review November 16, 2022 18:15
@sanders41 sanders41 marked this pull request as draft November 16, 2022 18:15
@sanders41 sanders41 marked this pull request as ready for review November 16, 2022 21:45
@sanders41 sanders41 requested a review from a team November 16, 2022 21:45
@chriscalhoun1974 chriscalhoun1974 mentioned this pull request Nov 29, 2022
Merged
6 tasks
eastandwestwind
eastandwestwind requested changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this so far @sanders41 !

Just have a couple requests / questions.

In addition, do we have another ticket to add docs for configuring these privacy request notifications?

src/fides/api/ops/api/v1/endpoints/privacy_request_endpoints.py Show resolved Hide resolved
src/fides/api/ops/api/v1/endpoints/privacy_request_endpoints.py Outdated Show resolved Hide resolved
src/fides/api/ops/email_templates/templates/privacy_request_error_notification.html Outdated Show resolved Hide resolved
src/fides/api/ops/service/messaging/message_dispatch_service.py Outdated Show resolved Hide resolved
src/fides/api/ops/api/v1/scope_registry.py Show resolved Hide resolved
@sanders41 sanders41 mentioned this pull request Dec 7, 2022
Closed
@sanders41
Copy link
Contributor Author

sanders41 commented Dec 7, 2022 •
edited
Loading

@eastandwestwind ready for another review.

In addition, do we have another ticket to add docs for configuring these privacy request notifications?

Good question. I haven't seen a ticket for this so I created one here #1997

eastandwestwind
eastandwestwind approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making those changes, looks good to me!

@sanders41 sanders41 merged commit d74ac56 into main Dec 8, 2022
@sanders41 sanders41 deleted the ps-error-email-alerts branch December 8, 2022 20:52
@adamsachs adamsachs mentioned this pull request Dec 8, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DSR configure alerts (BE)
2 participants
@sanders41 @eastandwestwind